Skip to content

Fix Typo mistake #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faheemshaikh121010 wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

Fix Typo mistake #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8874329
Merge pull request #1 from stacksimplify/master
faheemshaikh121010 Apr 1, 2026
7334256
Fix typo and update comments in README
faheemshaikh121010 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 08-NEW-ELB-Application-LoadBalancers/08-06-Deploy-ExternalDNS-on-EKS/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Kalyans-Mac-mini:08-06-ALB-Ingress-ExternalDNS kalyanreddy$
```yaml
eks.amazonaws.com/role-arn: arn:aws:iam::180789647333:role/eksctl-eksdemo1-addon-iamserviceaccount-defa-Role1-JTO29BVZMA2N
```
### Chnage-2: Line 55, 56: Commented them
### Change-2: Line 55, 56: Commented them
- We used eksctl to create IAM role and attached the `AllowExternalDNSUpdates` policy
- We didnt use KIAM or Kube2IAM so we don't need these two lines, so commented
```yaml
Expand Down