[6.x] Tolerate a folded X-Statamic-Pagination header when warming#14882
Open
mynetx wants to merge 1 commit into
Open
[6.x] Tolerate a folded X-Statamic-Pagination header when warming#14882mynetx wants to merge 1 commit into
mynetx wants to merge 1 commit into
Conversation
A proxy or CDN can fold the three X-Statamic-Pagination header values into a single comma-joined line, so statamic:static:warm and its queued job threw an Undefined array key error when destructuring it. Normalize both framings before destructuring, keeping a page name that contains a comma intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
statamic:static:warmcrashes withUndefined array key 1when it warms a paginated page behind a proxy or CDN. The static caching middleware setsX-Statamic-Paginationas three separate header values, but a proxy may fold repeated headers into a single comma-joined line, sogetHeader()returns one element and the[$current, $total, $name] = …destructure blows up. The--queuepath hits the same thing.A small
NormalizesPaginationHeadertrait normalizes both framings before destructuring, keeping a page name that itself contains a comma intact. The middleware always emits three values, so the helper assumes three.Fixes #14857