[6.x] Pass active query scope handles to relationship index scopes#14883
Open
mynetx wants to merge 1 commit into
Open
[6.x] Pass active query scope handles to relationship index scopes#14883mynetx wants to merge 1 commit into
mynetx wants to merge 1 commit into
Conversation
The entries/relationship fieldtype index applied each configured query scope with the raw request params, which never included the list of active scope handles. A scope registered under multiple aliases couldn't tell which one was in effect. Merge the configured handles into the params as queryScopes, the same way the asset browser does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entries/relationship field with
query_scopesapplies each scope with$request->all()during the CP index (the entry picker), but that never includes the list of active scope handles. A scope registered under multiple aliases — one class backing several handles — can't tell which one is in effect, so it can't apply the right filter.Relationship::applyIndexQueryScopes()now merges the field's configured handles into the params asqueryScopes, the same way the asset browser passes them.Fixes #14204