Skip to content

ingest/ledgerbackend: fix rpc ledger backend retries#5718

Merged
sreuland merged 12 commits intomasterfrom
rpc_backend_fix
Jun 13, 2025
Merged

ingest/ledgerbackend: fix rpc ledger backend retries#5718
sreuland merged 12 commits intomasterfrom
rpc_backend_fix

Conversation

@sreuland
Copy link
Copy Markdown
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Added new error code checking on GetLedgers response from RPC.

Why

RPC may emit a jrpc2 Error from GetLedgers when a request exceeds internal duration limits configured in rpc, if this type of error does occur, the rpc ledger backend as client should retry, it's not a fatal error.

Known limitations

@sreuland sreuland changed the title ingest/ledgerbackend: fix rpc ledger backend to retry requests if request duration limit errs ingest/ledgerbackend: fix rpc ledger backend to retry requests if duration limit errs Jun 10, 2025
Comment thread ingest/ledgerbackend/rpc_backend.go Outdated
…nges on rpc server side per stellar-rpc/pull/407
@sreuland sreuland requested a review from Shaptic June 12, 2025 16:15
Comment thread ingest/ledgerbackend/rpc_backend.go Outdated
Comment thread ingest/ledgerbackend/rpc_backend.go Outdated
@sreuland sreuland requested a review from urvisavla June 12, 2025 22:47
Copy link
Copy Markdown
Contributor

@urvisavla urvisavla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sreuland sreuland changed the title ingest/ledgerbackend: fix rpc ledger backend to retry requests if duration limit errs ingest/ledgerbackend: fix rpc ledger backend retries Jun 13, 2025
@sreuland sreuland merged commit 65b2d61 into master Jun 13, 2025
19 checks passed
urvisavla pushed a commit that referenced this pull request Jun 14, 2025
* ingest: Rpc as a ledger backend (#5699)

* ingest/ledgerbackend: fix rpc ledger backend retries (#5718)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants