services/galexie: add implementation for S3 and S3-compatible data storage.#5748
Merged
urvisavla merged 2 commits intostellar:masterfrom Jul 13, 2025
Merged
services/galexie: add implementation for S3 and S3-compatible data storage.#5748urvisavla merged 2 commits intostellar:masterfrom
urvisavla merged 2 commits intostellar:masterfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
overcat
changed the title
overcat
commented
Jul 10, 2025
urvisavla
reviewed
Jul 11, 2025
urvisavla
reviewed
Jul 11, 2025
urvisavla
approved these changes
Jul 11, 2025
Contributor
urvisavla
left a comment
urvisavla
left a comment
There was a problem hiding this comment.
This looks great! excellent test coverage!
7 tasks
Contributor
Author
|
Hi @urvisavla, I added integration tests in the new PR #5749, but let's merge this PR first. |
tamirms
reviewed
Jul 18, 2025
Comment on lines
+235
to
+238
| if errors.As(err, &noSuchKeyErr) || errors.As(err, ¬FoundErr) { | ||
| return true | ||
| } | ||
| return false |
Contributor
There was a problem hiding this comment.
can be simplified to:
return errors.As(err, &noSuchKeyErr) || errors.As(err, ¬FoundErr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Closes #5746
Why
See #5746
Known limitations
Integration tests have not been added yet.