Skip to content

services/horizon/docker: adjust verify range data file purge#5760

Merged
sreuland merged 5 commits intostellar:masterfrom
sreuland:verify_range_purge_data
Jul 18, 2025
Merged

services/horizon/docker: adjust verify range data file purge#5760
sreuland merged 5 commits intostellar:masterfrom
sreuland:verify_range_purge_data

Conversation

@sreuland
Copy link
Copy Markdown
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

remove file attribute reset during verify-range image's data file purge routine

Why

the pre-emptive fle attribute reset with chattr is not necessary, once pg is stopped the working data files path is ready for deletion. additionally, the file attrib reset wasn't compatible if the images /data path is mounted to an efs volume which by default has a file system that chattr doesn't work.

Related to: #5741

Known limitations

@sreuland sreuland requested review from tamirms and urvisavla July 16, 2025 21:29
@sreuland sreuland merged commit 56335b4 into stellar:master Jul 18, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants