xdr: add SafeUnmarshalBase64WithOptions and regenerate#5916
xdr: add SafeUnmarshalBase64WithOptions and regenerate#5916tamirms merged 1 commit intostellar:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
tamirms
force-pushed
the
fix-allocation
branch
4 times, most recently
from
3a8e409 to
bfeb789
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the SDK’s XDR decoding helpers to support caller-specified decode limits/options (via a new SafeUnmarshalBase64WithOptions) and updates the repository’s go-xdr/xdrgen inputs and Go toolchain targets accordingly.
Changes:
- Add
SafeUnmarshalBase64WithOptionsand re-exportDecodeOptionsfor consumers. - Update go-xdr dependency and xdrgen commit reference.
- Bump Go versions in
go.modand GitHub Actions workflow matrices.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
xdr/main.go |
Adds SafeUnmarshalBase64WithOptions, re-exports DecodeOptions, and adjusts base64/hex safe-unmarshal option initialization. |
go.mod |
Bumps Go version and updates github.com/stellar/go-xdr requirement. |
go.sum |
Updates checksums for the new go-xdr pseudo-version. |
Makefile |
Updates the pinned XDRGEN_COMMIT used for regeneration. |
.github/workflows/go.yml |
Updates CI Go version matrices (including adding 1.26). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…ze tracking Add SafeUnmarshalBase64WithOptions to accept DecodeOptions (including MaxOutputBytes) while always setting safe defaults for MaxInputLen and MaxDepth. Re-export DecodeOptions as a type alias so callers do not need to import go-xdr directly. Regenerate xdr_generated.go with output size tracking calls from updated xdrgen. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
SafeUnmarshalBase64WithOptionsacceptingDecodeOptions(includingMaxOutputBytes) while setting safe defaults forMaxInputLenandMaxDepthDecodeOptionsas a type alias so callers do not need to import go-xdr directlyxdr_generated.gowith output size tracking from updated xdrgen🤖 Generated with Claude Code