Combine the build and test jobs in the ci workflow#1579
Closed
leighmcculloch wants to merge 5 commits intomainfrom
Closed
Combine the build and test jobs in the ci workflow#1579leighmcculloch wants to merge 5 commits intomainfrom
leighmcculloch wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Combine the build and test jobs in the ci workflow.
Why
In #1576 I separated the build and test workflows as part of improving the reliability of the wasm builds, because I thought that the wasm builds used in tests would need to be produced by one host. But it turns out the wasm is stable on all of the hosts we build on. Also, even though the builds and tests were happening separately, the wasms were still being rebuilt in the tests, so it wasn't as effecient as I thought it would be.