Add exit code check to workflow that tests with soroban-examples diff step#1596
Merged
leighmcculloch merged 6 commits intomainfrom Oct 17, 2025
Merged
Add exit code check to workflow that tests with soroban-examples diff step#1596leighmcculloch merged 6 commits intomainfrom
leighmcculloch merged 6 commits intomainfrom
Conversation
graydon
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add exit code validation to the diff step in the soroban-examples workflow.
Why
The workflow expects a diff to exist after regeneration. Without exit code checking, the step passes even when no diff is present, masking if the workflow stops working at patching the sdk.