Expand the proc-macro composability test vector#1600
Merged
leighmcculloch merged 2 commits intomainfrom Oct 20, 2025
Merged
Conversation
dmkozh
approved these changes
Oct 20, 2025
leighmcculloch
deleted the
add-use-of-impl-item-proc-macro-to-test-vector
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add parse_item_impl attribute macro that parses impl blocks and apply it to contractimpl to test macro composition.
Why
The existing tests only validated function-level macro composition. This verifies that soroban-sdk macros compose correctly with impl-level attribute macros. What's under test is pretty minor but easy to test to include so why not.
For #1544