Refactor out excessive borrowed value optimizations in macros#1610
Merged
leighmcculloch merged 1 commit intomainfrom Oct 31, 2025
Merged
Refactor out excessive borrowed value optimizations in macros#1610leighmcculloch merged 1 commit intomainfrom
leighmcculloch merged 1 commit intomainfrom
Conversation
graydon
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace borrowed references with owned values in
impl_pub_methodsandFn, which are internal functions and types in the soroban-sdk-macros.Why
The excessive use of borrowed references and lifetime annotations was adding unnecessary complexity without meaningful performance benefits in macro expansion code that runs at compile time. Several times when I've worked with this code I have found it harder to evolve because of the limitation on data having to be owned externally to these functions.