Skip to content

Update stellar-strkey.#1658

Closed
fnando wants to merge 2 commits intostellar:release/v25-previewfrom
fnando:update-strkey
Closed

Update stellar-strkey.#1658
fnando wants to merge 2 commits intostellar:release/v25-previewfrom
fnando:update-strkey

Conversation

@fnando
Copy link
Copy Markdown
Member

@fnando fnando commented Dec 19, 2025

What

Update stellar-strkey.

Why

To have the latest version.

Known limitations

N/A

@fnando fnando requested a review from sisuresh December 19, 2025 16:33
@leighmcculloch
Copy link
Copy Markdown
Member

leighmcculloch commented Jan 5, 2026

The cargo-deny CI check is failing because this PR results in two versions of the strkey library being imported to contracts because v13 is still imported into the soroban-env-* crates. Can the version be updated there first so that there isn't two versions of the crate compiled on new builds for contract devs?

@mootz12
Copy link
Copy Markdown
Contributor

mootz12 commented Jan 7, 2026

Can the version be updated there first so that there isn't two versions of the crate compiled on new builds for contract devs?

Started making PRs for this and I think it needs to be updated in rs-stellar-xdr first.

@leighmcculloch leighmcculloch marked this pull request as draft January 8, 2026 11:27
@leighmcculloch leighmcculloch deleted the branch stellar:release/v25-preview January 12, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants