Skip to content

feat: add try_as_contract test function#1662

Merged
mootz12 merged 8 commits intomainfrom
issues/1434-try-as-contract
Feb 5, 2026
Merged

feat: add try_as_contract test function#1662
mootz12 merged 8 commits intomainfrom
issues/1434-try-as-contract

Conversation

@mootz12
Copy link
Copy Markdown
Contributor

@mootz12 mootz12 commented Jan 2, 2026 •
edited
Loading

What

Adds a try_as_contract fn that gracefully returns errors like try_invoke_contract.

Why

Fixes #1434

Known limitations

leighmcculloch
leighmcculloch reviewed Jan 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback inline.

Comment thread soroban-sdk/src/env.rs Outdated
Comment thread soroban-sdk/src/env.rs Outdated
Base automatically changed from release/v25-preview to main January 12, 2026 23:54
@mootz12 mootz12 changed the title feat: add try_as_contract fn feat: add try_as_contract test function Jan 14, 2026
@mootz12 mootz12 marked this pull request as ready for review January 14, 2026 18:54
Copilot AI review requested due to automatic review settings January 14, 2026 18:54

This comment was marked as outdated.

Sign in to view

@mootz12 mootz12 force-pushed the issues/1434-try-as-contract branch from 62fccb5 to 4b9ace5 Compare January 14, 2026 19:15
@mootz12 mootz12 requested a review from Copilot January 14, 2026 19:16
Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Comment thread soroban-sdk/src/env.rs
@mootz12 mootz12 requested a review from a team January 14, 2026 19:33
leighmcculloch
leighmcculloch approved these changes Feb 5, 2026
View reviewed changes
Comment thread soroban-sdk/src/tests/env.rs Outdated
Comment thread soroban-sdk/src/tests/env.rs Outdated
Comment thread soroban-sdk/src/tests/env.rs Outdated
Comment thread soroban-sdk/src/tests/env.rs Outdated
Comment thread soroban-sdk/src/tests/env.rs Outdated
Comment thread soroban-sdk/src/env.rs Outdated
Comment thread soroban-sdk/src/env.rs Outdated
Comment thread soroban-sdk/src/env.rs Outdated
Comment thread soroban-sdk/src/env.rs
Comment thread soroban-sdk/src/env.rs Outdated
@mootz12 mootz12 enabled auto-merge February 5, 2026 21:14
@mootz12 mootz12 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit af49990 Feb 5, 2026
91 of 94 checks passed
@mootz12 mootz12 deleted the issues/1434-try-as-contract branch February 5, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add try_as_contract function

3 participants

@mootz12 @leighmcculloch