Skip privacy-pools in soroban-examples CI#1811
Merged
leighmcculloch merged 6 commits intomainfrom Apr 1, 2026
Merged
Conversation
leighmcculloch
changed the title
leighmcculloch
requested review from
a team and
mootz12
and removed request for
mootz12
Contributor
There was a problem hiding this comment.
Pull request overview
Excludes the privacy-pools example from the soroban-examples CI matrix to avoid dependency conflicts that lead to duplicate soroban-sdk builds and panic_impl lang item errors.
Changes:
- Adds a
matrix.excludeentry forprivacy-poolsin the soroban-examples CI workflow. - Documents the rationale for excluding examples that pull in
soroban-sdktransitively via crates.io dependencies.
mootz12
approved these changes
Apr 1, 2026
Co-authored-by: mootz12 <38118608+mootz12@users.noreply.github.com>
jayz22
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exclude the
privacy-poolsexample from the soroban-examples CI matrix.Why
It depends on
soroban-poseidon, which transitively depends onsoroban-sdkfrom crates.io. Cargo cannot override a transitive dependency when the version does not match the semver compatibility range defined by the importer, resulting in two copies ofsoroban-sdkand duplicatepanic_impllang item errors.Close #1723