age: Replace HashSet with BTreeSet for deterministic iteration#612
Open
antonleviathan wants to merge 1 commit intostr4d:mainfrom
Open
age: Replace HashSet with BTreeSet for deterministic iteration#612antonleviathan wants to merge 1 commit intostr4d:mainfrom
antonleviathan wants to merge 1 commit intostr4d:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to remove a source of nondeterminism in age's label handling.
In downstream reproducible-build testing, we were seeing otherwise-identical builds produce different
zcash-devtoolbinaries.diffoscopenarrowed that down to code generation differences inage::error::PluginError::fmt, which pointed back to non-deterministic iteration order fromHashSet-backed label metadata. Switching these paths toBTreeSetmakes the iteration order deterministic.I tested this by pointing
zcash-devtoolat a local checkout of this branch and rebuilding with the patched age crate.