Skip to content

fix(cli): handle blank project password prompt #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgoux merged 1 commit into from
Jun 15, 2026
+10 −1
Merged

fix(cli): handle blank project password prompt #5569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/cli/src/shared/output/output.layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ export const textOutputLayer = Layer.effect(
cancel("Operation cancelled.");
return yield* Effect.interrupt;
}
return value.trim();
return typeof value === "string" ? value.trim() : "";
Comment thread
jgoux marked this conversation as resolved.
}),
promptConfirm: (message: string, opts?: { defaultValue?: boolean }) =>
Effect.gen(function* () {
Expand Down
9 changes: 9 additions & 0 deletions apps/cli/src/shared/output/output.layer.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,15 @@ describe("Output", () => {
}).pipe(Effect.provide(layer));
});

it.effect("promptPassword treats an undefined response as blank input", () => {
mockClack.password.mockResolvedValue(undefined);
return Effect.gen(function* () {
const out = yield* Output;
const result = yield* out.promptPassword("Enter password");
expect(result).toBe("");
}).pipe(Effect.provide(layer));
});

it.effect("promptConfirm interrupts on cancel", () => {
mockClack.confirm.mockResolvedValue(Symbol.for("clack:cancel"));
mockClack.isCancel.mockReturnValue(true);
Expand Down
Loading