Skip to content

fix(cli): accept nullable function import map paths#5577

Merged
avallete merged 4 commits into
supabase:developfrom
7ttp:fix/functions-list-null
Jun 15, 2026
Merged

fix(cli): accept nullable function import map paths#5577
avallete merged 4 commits into
supabase:developfrom
7ttp:fix/functions-list-null

Conversation

@7ttp

@7ttp 7ttp commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

TL;DR

fixes nullable function import map paths

prob

  • While testing the ported functions deploy flow here: feat(cli): port functions deploy #5561
    I found that functions list could fall back to request_failed because the management api can return
    import_map_path: null

Go already accepted that null shape, but the generated ts contract only accepted a string

basically this updates the generated function response contracts to accept null for import_map_path
and adds a integration coverage around it!

ref

@7ttp 7ttp requested a review from a team as a code owner June 15, 2026 08:18
@7ttp 7ttp changed the title fix(cli): accept nullable function import map paths fix(cli): accept nullable function import map paths Jun 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29bb580491

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/api/src/generated/contracts.ts
Comment thread packages/api/src/generated/contracts.ts Outdated
@7ttp 7ttp self-assigned this Jun 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a442e6f850

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/api/src/generated/contracts.ts
Comment thread packages/api/src/generated/contracts.ts
Comment thread packages/api/src/generated/openapi.json Outdated
@7ttp 7ttp requested review from Coly010, avallete and jgoux June 15, 2026 11:25
@avallete avallete added this pull request to the merge queue Jun 15, 2026
@avallete avallete removed this pull request from the merge queue due to a manual request Jun 15, 2026
@avallete avallete added this pull request to the merge queue Jun 15, 2026
Merged via the queue into supabase:develop with commit 2815a69 Jun 15, 2026
34 checks passed
@7ttp 7ttp deleted the fix/functions-list-null branch June 15, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants