Skip to content

feat(zoom): zoom connector [needs testing]#1012

Open
sreedharsreeram wants to merge 4 commits into
mainfrom
feat/zoom-connector
Open

feat(zoom): zoom connector [needs testing]#1012
sreedharsreeram wants to merge 4 commits into
mainfrom
feat/zoom-connector

Conversation

@sreedharsreeram

Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 27, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 8eb0294 Jul 14 2026, 03:54 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 27, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 8eb0294 Commit Preview URL

Branch Preview URL
Jul 14 2026, 03:55 PM

@claude

claude Bot commented May 27, 2026

Copy link
Copy Markdown

Claude finished @ishaanxgupta's task in 1m 42s —— View job


Review Complete

  • Fetch PR diff and existing review comments
  • Analyze changes for bugs, security issues, and logic errors
  • Check maintainer feedback about schema changes
  • Submit review

Summary: Clean UI-only changes that follow existing connector patterns. No bugs, security issues, or breaking changes found. The authLink/expiresIn optional schema is pre-existing (not introduced by this PR) and accommodates credential-based providers like Granola. Ready to merge once the Zoom backend integration ships.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds Zoom as a new connector option in the web UI, wiring it into the add-document dropdown and settings page.

Issues found: None — this looks good to ship.

The changes follow the existing patterns for other connectors (Google Drive, Notion, OneDrive):

  • Zoom added to ConnectorProvider type and CONNECTORS config in both connection components
  • Provider added to API schema with correct enum updates
  • Display name and import provider type added to sync-utils
  • Icon component added using embedded base64 PNG

The authLink and expiresIn fields were made optional in the API schema, which is properly handled — the frontend already uses optional chaining (data?.authLink) before redirecting.

Score: 9/10

Minor note: The title says "[needs testing]" which is appropriate. Ensure the backend Zoom connection handler is in place and returns the expected response format before merging.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sreedharsreeram sreedharsreeram removed the request for review from Dhravya May 27, 2026 02:37
@Dhravya

Dhravya commented Jul 11, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution! Holding this for now — the Zoom connector isn't released yet on the backend side, so we don't want to surface the option in the UI until it's live end-to-end. We'll revisit and get this merged once the Zoom integration ships.

One small ask in the meantime: the schema change makes authLink/expiresIn optional for all providers — once the Zoom endpoint returns an authLink like the other OAuth providers, that loosening shouldn't be needed and it'd be good to revert it so a missing link fails loudly instead of leaving the button stuck on "connecting".

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds Zoom as a new connector option in the web UI, wiring it into the add-document dropdown, settings page, and API schema.

Issues found: None — this looks good to ship when the backend is ready.

The changes follow the established patterns for other connectors (Google Drive, Notion, OneDrive, Granola):

  • Zoom added to ConnectorProvider type and CONNECTORS config in both connection components
  • Provider enum updated in API schema for both connection and import endpoints
  • Display name and import provider type added to sync-utils
  • Icon component added with embedded SVG/base64 PNG

Re: maintainer feedback on authLink/expiresIn being optional — the current diff only adds "zoom" to the provider enum; the optional schema already exists (with a comment explaining it accommodates credential-based providers like Granola). Once the Zoom backend returns authLink like other OAuth providers, the existing frontend code at connections.tsx:433 will redirect correctly.

Score: 9/10

Ready to merge once the Zoom backend integration ships.

- Fix missing closing tags in Zoom icon component (icons.tsx)
- Apply Biome formatting to connections.tsx and api.ts

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants