Skip to content

company brain responsiveness#1239

Merged
graphite-app[bot] merged 1 commit into
mainfrom
company-brain-responsiveness
Jul 16, 2026
Merged

company brain responsiveness#1239
graphite-app[bot] merged 1 commit into
mainfrom
company-brain-responsiveness

Conversation

@ishaanxgupta

@ishaanxgupta ishaanxgupta commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Improves the Company Brain header and stats cards on mobile without changing the desktop layout intent.
  • Tightens the mobile Slack banner so the Slack logo is not duplicated and the card stays compact.
  • Centers the onboarding step flow and card as one stack while keeping the logo independent.

before:
image

after:
image
image
image
image

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 11, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 8d92633 Jul 16 2026, 01:59 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 11, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 8d92633 Commit Preview URL

Branch Preview URL
Jul 16 2026, 02:00 AM

@ishaanxgupta ishaanxgupta marked this pull request as ready for review July 11, 2026 15:26
@claude

claude Bot commented Jul 11, 2026

Copy link
Copy Markdown

Claude finished @ved015's task in 1m 14s —— View job


Reviewing PR #1239

  • Fetch PR diff and existing review comments
  • Analyze changes for bugs, security issues, and logic errors
  • Post review summary

Overview: Mobile responsiveness improvements for Company Brain header, stats cards, Slack banner, onboarding shell, and source cards.

Issues found: None — this looks good to ship.

All changes are CSS/Tailwind class modifications for responsive layouts with two intentional behavior changes:

  1. normalizeDomain in company-brain-onboarding.tsx: Now appends .com to single-label inputs (e.g., "Zomato" → "zomato.com"). The regex ^[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?$ correctly identifies hostnames without a TLD and assumes .com — a reasonable UX improvement that prevents failed API round trips when users type company names instead of domains.

  2. step-sources.tsx: The Continue button no longer requires connectedCount > 0, and "Skip for now" is hidden on mobile (hidden sm:inline). This is necessary because mobile users need an always-enabled primary action to proceed. Desktop users still have the visible "Skip for now" link.

The triggerClassName prop added to SpaceSelector is already defined in its interface (space-selector.tsx:53).

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Mobile responsiveness improvements for Company Brain header, stats cards, Slack banner, and onboarding flow.

Issues found: None — this looks good to ship.

All changes are CSS/Tailwind class modifications for responsive layouts:

  • Stats row now uses 4 columns at all breakpoints with truncated labels and a compact mobile invite button
  • Slack banner tightens padding and uses shorter text on mobile
  • Header adjusts spacing and element sizing for narrow viewports
  • Onboarding shell centers the step indicator with the content card while keeping the logo independent
  • Source cards scale down icon sizes, text, and padding on mobile

The implementation correctly uses min-w-0, truncate, and overflow-hidden to prevent layout overflow on small screens. Accessibility is maintained with proper aria-label attributes on icon-only buttons.

Score: 10/10

@ishaanxgupta ishaanxgupta changed the title company brain responsivness company brain responsiveness Jul 11, 2026

@MaheshtheDev MaheshtheDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not completely company brain responsive

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Mobile responsiveness improvements for Company Brain header, stats cards, Slack banner, onboarding shell, and source cards.

Issues found: None — this looks good to ship.

All changes are CSS/Tailwind class modifications for responsive layouts with one intentional logic change:

  • Stats row: Now uses 4 columns at all breakpoints with truncated labels (MobileStatLabel component) and a compact mobile invite button
  • Slack banner: Tightens padding, uses smaller icons, and shows shorter text on mobile
  • Header: Adjusts spacing, element sizing, and adds aria-label for the mobile menu button
  • Onboarding shell: Repositions the logo as fixed header and centers the step indicator with content
  • Source cards: Scales down icon sizes, text, and padding on mobile with appropriate responsive breakpoints

The logic change in onboarding/page.tsx is well-documented: local dev now shows the stepped onboarding flow (bypassing the research surface) to enable responsive QA, while production behavior remains unchanged.

The implementation correctly uses min-w-0, truncate, and overflow-hidden to prevent layout overflow on small screens. The triggerClassName prop added to SpaceSelector is already defined in its interface.

Re: @MaheshtheDev's feedback — The comment "this is not completely company brain responsive" appears to be about scope/completeness (more components may need responsive work) rather than issues with the code in this PR. The changes here are solid.

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Mobile responsiveness improvements for Company Brain header, stats cards, Slack banner, onboarding shell, and source cards.

Issues found: None — this looks good to ship.

All changes are CSS/Tailwind class modifications for responsive layouts with one intentional behavior change:

  • Stats row: Uses 4 columns at all breakpoints with truncated labels (MobileStatLabel component) and a compact mobile invite button
  • Slack banner: Tightens padding, uses smaller icons, and shows shorter text on mobile
  • Header: Adjusts spacing, element sizing, and adds aria-label for the mobile menu button
  • Onboarding shell: Repositions the logo as fixed header and centers the step indicator with content
  • Source cards: Scales down icon sizes, text, and padding on mobile

Behavior change in step-sources.tsx: The Continue button's disabled={connectedCount === 0} was removed and "Skip for now" is hidden on mobile. This is intentional — on mobile, users need a working primary action button since the skip link is hidden. Desktop still has the visible "Skip for now" link.

Logic change in onboarding/page.tsx: Local dev now shows the stepped onboarding flow (bypassing the research surface) for responsive QA, while production behavior remains unchanged. This is documented in the comments.

The implementation correctly uses min-w-0, truncate, and overflow-hidden to prevent layout overflow on small screens.

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Mobile responsiveness improvements for Company Brain header, stats cards, Slack banner, onboarding shell, and source cards.

Issues found: None — this looks good to ship.

All changes are CSS/Tailwind class modifications for responsive layouts with one intentional behavior change:

  • Stats row: Uses 4 columns at all breakpoints with truncated labels (MobileStatLabel component) and a compact mobile invite button
  • Slack banner: Tightens padding, uses smaller icons, and shows shorter text on mobile
  • Header: Adjusts spacing, element sizing, and adds aria-label for the mobile menu button
  • Onboarding shell: Repositions the logo as fixed header and centers the step indicator with content
  • Source cards: Scales down icon sizes, text, and padding on mobile

Behavior change in step-sources.tsx: The Continue button's disabled={connectedCount === 0} was removed and "Skip for now" is hidden on mobile. This is intentional — on mobile, users need a working primary action button since the skip link is hidden. Desktop still has the visible "Skip for now" link.

Logic change in onboarding/page.tsx: Local dev now shows the stepped onboarding flow (bypassing the research surface) for responsive QA, while production behavior remains unchanged. This is documented in the comments.

The implementation correctly uses min-w-0, truncate, and overflow-hidden to prevent layout overflow on small screens.

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Mobile responsiveness improvements for Company Brain header, stats cards, Slack banner, onboarding shell, and source cards.

Issues found: None — this looks good to ship.

All changes are CSS/Tailwind class modifications for responsive layouts with two intentional behavior changes:

  1. normalizeDomain in company-brain-onboarding.tsx: Now appends .com to single-label inputs (e.g., "Zomato" → "zomato.com"). This handles the common case where users type a company name instead of a hostname — a reasonable UX improvement that prevents a failed API round trip.

  2. step-sources.tsx: The Continue button no longer requires connectedCount > 0. This is necessary because "Skip for now" is hidden on mobile (sm:inline), so users need an always-enabled Continue button to proceed. Desktop users can still skip via the visible link.

The local dev flag change (localCompanyBrainPreview) is clearly documented and only affects development builds.

Score: 10/10

@graphite-app

graphite-app Bot commented Jul 16, 2026

Copy link
Copy Markdown

Merge activity

## Summary

- Improves the Company Brain header and stats cards on mobile without changing the desktop layout intent.
- Tightens the mobile Slack banner so the Slack logo is not duplicated and the card stays compact.
- Centers the onboarding step flow and card as one stack while keeping the logo independent.

before:
<img width="388" height="864" alt="image" src="https://github.com/user-attachments/assets/f02890e4-78d1-45cf-a819-97306df20d5c" />

after:
<img width="193" height="431" alt="image" src="https://github.com/user-attachments/assets/1b5d6907-1dc1-4d95-9b4f-2b40defecda5" />
<img width="391" height="865" alt="image" src="https://github.com/user-attachments/assets/67fb6009-bace-4c78-9b72-b4dfcdd79b90" />
<img width="385" height="865" alt="image" src="https://github.com/user-attachments/assets/f3c3d785-762e-49c2-92bb-461358eda418" />
<img width="394" height="865" alt="image" src="https://github.com/user-attachments/assets/f5943779-a141-467d-a350-80678f3a2513" />
@graphite-app graphite-app Bot force-pushed the company-brain-responsiveness branch from 0f2a9fc to 8d92633 Compare July 16, 2026 01:57
@graphite-app graphite-app Bot merged commit 8d92633 into main Jul 16, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants