Conversation
…definitions Expand and clarify the plugin's documentation with individual parameter descriptions for selector and attributes. Add TypeScript parameter types via JSDoc typedefs and export them in lib/types.ts. Add parameter validation and warning to prevent runtime errors when plugin is not configured or misconfigured. Update type annotation to use RemoveAttributesBySelectorParams. Add tests to ensure plugin is a no-op when not configured. Co-Authored-By: soren121 <soren121@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm uncertain if the switch to
matchesin #1978 is a good idea perfwise. But it has a subset which are clearly good ideas, so this PR is just those.