Conversation
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
PR Review: ci: add manual Publish crates workflowOverviewThis adds a Issues1. 2. Nightly toolchain may be unnecessary 3. Deprecated 4. 5. No 6. Missing 7. No Minor Nits
SummaryThe core logic is sound — |
There was a problem hiding this comment.
Pull request overview
Adds a new manually triggered GitHub Actions workflow to run the crate version-bump + tagging flow on main, pushing the resulting commit and tags back to the repository (while keeping the existing auto publish workflow unchanged).
Changes:
- Introduce a new
workflow_dispatch-only workflow named Publish crates. - Configure the job to checkout
mainwith full history, authenticate via SSH, runcargo bump, and pushmain+ tags. - Set consistent bot author/committer environment variables for generated commits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| git push origin main | ||
| git push origin --tags |
There was a problem hiding this comment.
git push origin --tags will attempt to push all local tags (and the job is also vulnerable to being cancelled between the branch push and the tag push), which can cause surprising behavior or leave the run half-complete (commit pushed but tag not). Prefer a single push that includes only the tags created by cargo bump (e.g. push the specific tag(s) or use a follow-tags approach) so the operation is atomic and limited in scope.
| git push origin main | |
| git push origin --tags | |
| git push --atomic --follow-tags origin main |
| SKIP_YARN_COREPACK_CHECK: 1 | ||
|
|
||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
The workflow sets permissions: contents: write, but all write operations are performed via SSH (not GITHUB_TOKEN) and no step appears to require write-scoped token permissions. Consider reducing this to contents: read (or removing the override) to follow least-privilege and reduce blast radius if a dependency/action is compromised.
| contents: write | |
| contents: read |
Binary Sizes
Commit: f6ac886 |
Summary
Publish cratesgit pull->cargo bump->git push->git push --tagsDetails
workflow_dispatch(no inputs)mainwith full historySWC_BOT_SSHand force SSH remote URL before push