Fixed stuck backstack on invalid entries - #4293
Open
TheVimDev wants to merge 2 commits into
Open
Conversation
3 tasks
TheVimDev
force-pushed
the
fixed_backstack
branch
from
August 26, 2026 17:29
c511855 to
922155c
Compare
TheVimDev
force-pushed
the
fixed_backstack
branch
from
August 26, 2026 18:14
922155c to
8e37d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR resolve?
Resolves #4292
Rationale of this PR
Upon every shift, be in backward or forward, there are now checks that check for validity. Furthermore, if an entry is found invalid, the entry is removed from the backtrace and nearby entries are checks for duplication. That prevent "no-op" situation where three entries would be A-X-A, X would be found invalid and now A-A would be next to each other. That would result in shift not doing anything, because it'd check the position from position A to A -> nothing would happen
Checklist
I did not use any LLM for anything at all. I looked at yazi to understand the problem, I wrote the code and tested it to check if it's working or not