Skip to content

fix: bump aws-sdk-go-v2 SDKs for AWS European Sovereign Cloud (EUSC) support#1309

Merged
synfinatic merged 1 commit into
synfinatic:mainfrom
wabicloud:fix/eusc-region-support
May 10, 2026
Merged

fix: bump aws-sdk-go-v2 SDKs for AWS European Sovereign Cloud (EUSC) support#1309
synfinatic merged 1 commit into
synfinatic:mainfrom
wabicloud:fix/eusc-region-support

Conversation

@nlang
Copy link
Copy Markdown
Contributor

@nlang nlang commented Apr 28, 2026

Summary

  • Bump service/sso v1.22.1 → v1.30.16 and service/ssooidc v1.26.2 → v1.35.20 (plus required transitive aws-sdk-go-v2 core / smithy-go / internal/configsources / internal/endpoints/v2 bumps).
  • These SDK versions add the aws-eusc partition with the correct DNS suffix amazonaws.eu and the regex ^eusc-(de)-\w+-\d+$. Without it, the SDK falls back to amazonaws.com and DNS resolution for EUSC endpoints (e.g. oidc.eusc-de-east-1.amazonaws.com) fails.
  • The new SDK modules require Go 1.24, so the go directive in go.mod is raised from 1.23 to 1.24.
  • No code changes — ssooidc.New(...) / sso.New(...) already let the SDK resolve the partition from the region.

Motivation

End users in the EU Sovereign Cloud (region eusc-de-east-1) currently hit:

dial tcp: lookup oidc.eusc-de-east-1.amazonaws.com: no such host
dial tcp: lookup portal.sso.eusc-de-east-1.amazonaws.com: no such host

because the vendored SDKs predate the aws-eusc partition.

Test plan

  • go build ./... clean
  • go test ./... all packages pass
  • go vet ./... clean
  • End-to-end verified by the reporter: RegisterClient and StartDeviceAuthorization against eusc-de-east-1 now resolve to *.amazonaws.eu and the device authorization flow completes.

Note on Go version

go.mod is bumped to go 1.24 because the upgraded SDK modules declare it as their minimum. If vars.GO_VERSION in CI is still below 1.24, it will need to be raised together with this change.

@synfinatic
Copy link
Copy Markdown
Owner

synfinatic commented May 9, 2026

@nlang gonna need you to rebase as we're now on GO 1.26.3. github worker issue :(. seems GH stability is biting us here... give it some time and will try again for this and your other PR.

@synfinatic
Copy link
Copy Markdown
Owner

@nlang can you rebase?

@nlang nlang force-pushed the fix/eusc-region-support branch from 265be7e to ea5d2fa Compare May 10, 2026 09:39
@nlang
Copy link
Copy Markdown
Contributor Author

nlang commented May 10, 2026

done :)

@synfinatic
Copy link
Copy Markdown
Owner

@nlang sorry, one more time (this and your other PR). removed all the github vars from the workflows which were breaking the build since github won't pass them into PR's from a fork.

…support

The AWS European Sovereign Cloud uses the `aws-eusc` partition with a
distinct DNS suffix (`amazonaws.eu`), and regions named `eusc-de-east-1`,
etc. The previously vendored versions of `service/sso` (v1.22.1) and
`service/ssooidc` (v1.26.2) predate that partition and fall back to the
default `amazonaws.com` suffix, producing DNS lookup failures such as:

  dial tcp: lookup oidc.eusc-de-east-1.amazonaws.com: no such host
  dial tcp: lookup portal.sso.eusc-de-east-1.amazonaws.com: no such host

Bumping `service/sso` to v1.30.16 and `service/ssooidc` to v1.35.20
introduces the partition entry and the correct hostnames
(`oidc.{region}.amazonaws.eu`, `portal.sso.{region}.amazonaws.eu`).

Required transitive bumps: `aws-sdk-go-v2` core, `internal/configsources`,
`internal/endpoints/v2`, `smithy-go`. The new SDK modules require Go 1.24,
so the `go` directive is raised accordingly.

No code changes are needed: SSO/OIDC clients are already constructed with
just the region, and the partition/endpoint resolution is handled by the
SDK once the partition is known.
@nlang nlang force-pushed the fix/eusc-region-support branch from ea5d2fa to f627eb7 Compare May 10, 2026 16:48
@nlang
Copy link
Copy Markdown
Contributor Author

nlang commented May 10, 2026

sure, here you go ;)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.85%. Comparing base (da16a7f) to head (f627eb7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1309   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files          44       44           
  Lines        3465     3465           
=======================================
  Hits         2940     2940           
  Misses        422      422           
  Partials      103      103           
Flag Coverage Δ
unittests 84.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da16a7f...f627eb7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@synfinatic synfinatic merged commit 29a291c into synfinatic:main May 10, 2026
8 checks passed
Copilot AI mentioned this pull request May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants