fix: bump aws-sdk-go-v2 SDKs for AWS European Sovereign Cloud (EUSC) support#1309
Conversation
|
@nlang |
|
@nlang can you rebase? |
265be7e to
ea5d2fa
Compare
|
done :) |
|
@nlang sorry, one more time (this and your other PR). removed all the github vars from the workflows which were breaking the build since github won't pass them into PR's from a fork. |
…support
The AWS European Sovereign Cloud uses the `aws-eusc` partition with a
distinct DNS suffix (`amazonaws.eu`), and regions named `eusc-de-east-1`,
etc. The previously vendored versions of `service/sso` (v1.22.1) and
`service/ssooidc` (v1.26.2) predate that partition and fall back to the
default `amazonaws.com` suffix, producing DNS lookup failures such as:
dial tcp: lookup oidc.eusc-de-east-1.amazonaws.com: no such host
dial tcp: lookup portal.sso.eusc-de-east-1.amazonaws.com: no such host
Bumping `service/sso` to v1.30.16 and `service/ssooidc` to v1.35.20
introduces the partition entry and the correct hostnames
(`oidc.{region}.amazonaws.eu`, `portal.sso.{region}.amazonaws.eu`).
Required transitive bumps: `aws-sdk-go-v2` core, `internal/configsources`,
`internal/endpoints/v2`, `smithy-go`. The new SDK modules require Go 1.24,
so the `go` directive is raised accordingly.
No code changes are needed: SSO/OIDC clients are already constructed with
just the region, and the partition/endpoint resolution is handled by the
SDK once the partition is known.
ea5d2fa to
f627eb7
Compare
|
sure, here you go ;) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
=======================================
Coverage 84.85% 84.85%
=======================================
Files 44 44
Lines 3465 3465
=======================================
Hits 2940 2940
Misses 422 422
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary
service/ssov1.22.1 → v1.30.16 andservice/ssooidcv1.26.2 → v1.35.20 (plus required transitiveaws-sdk-go-v2core /smithy-go/internal/configsources/internal/endpoints/v2bumps).aws-euscpartition with the correct DNS suffixamazonaws.euand the regex^eusc-(de)-\w+-\d+$. Without it, the SDK falls back toamazonaws.comand DNS resolution for EUSC endpoints (e.g.oidc.eusc-de-east-1.amazonaws.com) fails.godirective ingo.modis raised from 1.23 to 1.24.ssooidc.New(...)/sso.New(...)already let the SDK resolve the partition from the region.Motivation
End users in the EU Sovereign Cloud (region
eusc-de-east-1) currently hit:because the vendored SDKs predate the
aws-euscpartition.Test plan
go build ./...cleango test ./...all packages passgo vet ./...cleanRegisterClientandStartDeviceAuthorizationagainsteusc-de-east-1now resolve to*.amazonaws.euand the device authorization flow completes.Note on Go version
go.modis bumped togo 1.24because the upgraded SDK modules declare it as their minimum. Ifvars.GO_VERSIONin CI is still below 1.24, it will need to be raised together with this change.