preempt_sched: use sa_sigaction for SA_SIGINFO#27
Open
Charlie-Tsai1123 wants to merge 1 commit into
Open
Conversation
According to sigaction(2), when SA_SIGINFO is specified in sa_flags, the signal handler should be sa_sigaction instead of sa_handler. timer_handler() uses the three-argument signal handler form, but the current code registers it through sa_handler by casting it to a one-argument handler type. Use sa_sigaction to match the documented API and avoid casting between incompatible function pointer types. Reference: https://man7.org/linux/man-pages/man2/sigaction.2.html
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to sigaction(2), when SA_SIGINFO is specified in sa_flags, the signal handler should be sa_sigaction instead of sa_handler.
timer_handler() uses the three-argument signal handler form, but the current code registers it through sa_handler by casting it to a one-argument handler type. Use sa_sigaction to match the documented API and avoid casting between incompatible function pointer types.
Reference:
https://man7.org/linux/man-pages/man2/sigaction.2.html
Summary by cubic
Use sa_sigaction for the timer signal when SA_SIGINFO is set, so the 3-arg handler is registered correctly. Also switch timer_handler’s third parameter to void* and remove the function-pointer cast, aligning with sigaction(2) and preventing undefined behavior.
Written for commit 4f9eae6. Summary will update on new commits.