Fix: Python single-line comments incorrectly highlighting subsequent lines#3
Open
hygjob wants to merge 2 commits into
Open
Fix: Python single-line comments incorrectly highlighting subsequent lines#3hygjob wants to merge 2 commits into
hygjob wants to merge 2 commits into
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
When rendering fenced Python code blocks, single-line comments starting with
#would incorrectly cause the next line to be rendered with comment styling (dim fallback) instead of proper syntax highlighting.Root Cause
syntect'sHighlightLines::highlight_line()requires a trailing newline (\n) to properly terminate line-based scopes such as Python single-line comments. Without it, the comment scope leaks into the next line's highlighting context.Changes
src/renderer.rs: Append a trailing newline to each line before callinghighlight_line(), then trim it from the resulting spans. Added a regression test (python_comment_does_not_affect_next_lines) to verify the fix.src/app.rs: Applied a minor clippy suggestion (or_else→orforOptionreferences).Verification