Skip to content

Copy github action to separate directory#338

Open
webwarrior-ws wants to merge 1 commit into
tarsgate:masterfrom
webwarrior-ws:move-github-action-1
Open

Copy github action to separate directory#338
webwarrior-ws wants to merge 1 commit into
tarsgate:masterfrom
webwarrior-ws:move-github-action-1

Conversation

@webwarrior-ws

Copy link
Copy Markdown
Collaborator

So when referenced by external repositories, it's more clear what the action does, as reference will include path to the action.

Original action.yml at the root is not deleted to not disrupt current users. After this gets merged into master, original file can be deleted.

So when referenced by external repositories, it's more
clear what the action does, as reference will include path
to the action.

Original action.yml at the root is not deleted to not disrupt
current users. After this gets merged into master, original
file can be deleted.
@knocte

knocte commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Mention action.yml in commit msg pls.

@webwarrior-ws

Copy link
Copy Markdown
Collaborator Author

Mention action.yml in commit msg pls.

It is already mentioned in the commit message.

@knocte

knocte commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

So when referenced by external repositories

Are we actually referencing it from external repos? I see we stopped using it in pulumi-deploy because we stopped using the pulumi action.

@webwarrior-ws

Copy link
Copy Markdown
Collaborator Author

So when referenced by external repositories

Are we actually referencing it from external repos? I see we stopped using it in pulumi-deploy because we stopped using the pulumi action.

Yes, we stopped using it from pulumi-deploy.

@knocte

knocte commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

So then this doesn't need to be 2 PRs, just one is enough, right?

@webwarrior-ws

Copy link
Copy Markdown
Collaborator Author

So then this doesn't need to be 2 PRs, just one is enough, right?

No, because this repository references the action as nblockchain/conventions@master.
Alternatively, it can be referenced as local action, in that case 1 PR should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants