feat: add Unwrap() []error to ParseError for errors.Is/As support#51
Open
Yanhu007 wants to merge 1 commit intotemoto:masterfrom
Open
feat: add Unwrap() []error to ParseError for errors.Is/As support#51Yanhu007 wants to merge 1 commit intotemoto:masterfrom
Yanhu007 wants to merge 1 commit intotemoto:masterfrom
Conversation
ParseError wraps multiple errors but did not implement the Unwrap() []error interface introduced in Go 1.20. This makes errors.Is and errors.As unable to inspect the underlying errors. Add the Unwrap method so callers can use standard library error inspection tools with ParseError. Fixes temoto#47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
Problem
ParseErrorwraps multiple errors in itsErrsfield but does not implement theUnwrap() []errorinterface (Go 1.20+). This meanserrors.Isanderrors.Ascannot inspect the underlying errors.Fix
Add the
Unwrapmethod:Testing
All existing tests pass.