Handle unavailable ShutdownWorker during graceful poll shutdown#1298
Open
noqcks wants to merge 4 commits into
Open
Handle unavailable ShutdownWorker during graceful poll shutdown#1298noqcks wants to merge 4 commits into
noqcks wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Fixes #1297.
Problem
When
DescribeNamespacereportsworker_poll_complete_on_shutdown=true, sdk-core enables graceful poll shutdown and lets in-flight long polls wait for server-side completion afterShutdownWorker. IfShutdownWorkerreturnsUNIMPLEMENTEDorUNAVAILABLE, that server-assisted path is unavailable, but the in-flight activity poll can still wait forever andpoll_activity_task()never returnsPollError::ShutDown.Solution
This draft adds a deterministic activity-only regression test. On
ShutdownWorkerUNIMPLEMENTED/UNAVAILABLE, the worker disables the existing graceful poll capability.LongPollBufferkeeps normal graceful behavior, but after local shutdown it observes that capability transition and lets the in-flight poll return shutdown instead of waiting forever.Design question: is observing the existing capability from
LongPollBufferacceptable, or should this be a more explicit poll-buffer shutdown signal?Artifacts (if appropriate):
N/A.