Test: revert signal approach for cancel test#1328
Closed
rkannan82 wants to merge 5 commits into
Closed
Conversation
- Move validate() into CoreWfStarter::worker() so all integration tests get namespace capabilities populated. Without this, tests checking capabilities like worker_commands were silently skipped. - Disable eager activity dispatch to work around a server bug where StartedClock is not set for eager activities, causing the worker command cancel path to be skipped. - Propagate activity errors so the test fails if cancel is not delivered. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit b125e5f.
rkannan82
force-pushed
the
kannan/revert-signal-test
branch
from
206f138 to
2387a56
Compare
Contributor
Author
|
Test passed after fixing dynamic config. Root cause: enableCancelActivityWorkerCommand was set per-namespace in cloud UI but the deployed server (v1.32.0-156.5) has it as a global bool, so the namespace-scoped value was silently ignored. Fixed by setting it at cell level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert signal-based synchronization back to 5s timer to test if cloud test passes.