💥 feat(sdk): error type for signal external workflow#1329
Draft
chris-olszewski wants to merge 2 commits into
Draft
💥 feat(sdk): error type for signal external workflow#1329chris-olszewski wants to merge 2 commits into
chris-olszewski wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ChildWorkflowSignalError->WorkflowSignalErrorExternalWorkflowHandle::signalto use same machinery as signaling child workflow instead ofSignalExternalFutWhy?
Failureas error typesChecklist
Closes N/A
How was this tested:
Updated test expect error instead of raw failure
Any docs updates needed?
N/A