fix: use network-aware token address for testnet balance queries#47
Open
crabanagent wants to merge 1 commit into
Open
fix: use network-aware token address for testnet balance queries#47crabanagent wants to merge 1 commit into
crabanagent wants to merge 1 commit into
Conversation
The usdcToken constant was hardcoded to the mainnet USDC.e address, so whoami --network testnet always showed 0 balance even when the wallet is funded on the moderato chain. Add a moderatoToken constant for the testnet token contract and a tokenAddress() helper that switches on chain ID, mirroring the existing escrowContract() pattern. Update all call sites in identity, fund, sessions, and transfer commands to use the network-aware token. Closes tempoxyz#46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whoami --network testnetalways showsbalance: 0even when the wallet is funded on the moderato chain (42431). TheusdcTokenconstant inconstants.tsis hardcoded to the mainnet USDC.e address, so balance queries on testnet hit the wrong token contract.Changes
moderatoTokenconstant for the testnet token contract (0x20c0…0000)tokenAddress(chain)helper innetwork.ts, mirroring the existingescrowContract(chain)patterntokenDecimals()andtokenSymbol()to recognize both mainnet and testnet token addressesidentity.ts,fund.ts,sessions.ts, andtransfer.tswith network-aware lookupstransfer.tsMPP challenge validation now accepts both mainnet and testnet tokensTesting
pnpm typecheck— passes ✅pnpm test— all 108 tests pass ✅Closes #46