Feat: Add missing attribute to bigquery subscription and cloud storage subscription variables#238
Merged
imrannayer merged 3 commits intoterraform-google-modules:mainfrom Mar 18, 2025
Conversation
…e subscription variables
Ram1604
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
Contributor
Author
|
Hi @ayushmjain, @imrannayer, @q2w, Can you please review this? |
Contributor
Author
|
Hi @imrannayer @q2w @ayushmjain Any updates on this? Kindly help me out here. |
Collaborator
|
@Ram1604 thx for the PR. Can you plz fix lint issues. |
Contributor
Author
|
Hi @imrannayer Thanks for responding. I have made the changes can you kindly check now? |
Collaborator
|
/gcbrun |
Contributor
Author
|
Hi @imrannayer Any ETA on when this will be merged? |
imrannayer
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to create BigQuery and Cloud storage subscriptions with enabled deadletter, I couldn't set the max_delivery_attempts, since the attribute is not present in the variable blocks of both subscription. The pull and push are okay.
(Note: There is one issue with pull subscriptions, could not able to set the expiration to never expire in them. Please take a look into them also.)