-
Notifications
You must be signed in to change notification settings - Fork 93
feat: add importOverrides as a variant of componentImports #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rpd10
wants to merge
2
commits into
testing-library:main
Choose a base branch
from
rpd10:rydiehl/import-overrides
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+144
−9
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
projects/testing-library/src/tests/import-overrides.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| import { Component } from '@angular/core'; | ||
| import { expect, test } from 'vitest'; | ||
| import { render, screen } from '../public_api'; | ||
|
|
||
| @Component({ | ||
| selector: 'atl-child', | ||
| template: `Hello from child`, | ||
| standalone: true, | ||
| }) | ||
| class ChildComponent {} | ||
|
|
||
| @Component({ | ||
| selector: 'atl-child', | ||
| template: `Hello from stub`, | ||
| standalone: true, | ||
| host: { 'collision-id': 'StubComponent' }, | ||
| }) | ||
| class StubChildComponent {} | ||
|
|
||
| @Component({ | ||
| selector: 'atl-other', | ||
| template: `Hello from other`, | ||
| standalone: true, | ||
| }) | ||
| class OtherComponent {} | ||
|
|
||
| @Component({ | ||
| selector: 'atl-fixture', | ||
| template: `<atl-child /><atl-other />`, | ||
| standalone: true, | ||
| imports: [ChildComponent, OtherComponent], | ||
| }) | ||
| class FixtureComponent {} | ||
|
|
||
| @Component({ | ||
| selector: 'atl-non-standalone', | ||
| template: `non-standalone`, | ||
| standalone: false, | ||
| }) | ||
| class NonStandaloneComponent {} | ||
|
|
||
| test('importOverrides - replaces a single import', async () => { | ||
| await render(FixtureComponent, { | ||
| importOverrides: [{ replace: ChildComponent, with: StubChildComponent }], | ||
| }); | ||
|
|
||
| expect(screen.getByText('Hello from stub')).toBeInTheDocument(); | ||
| expect(screen.queryByText('Hello from child')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('importOverrides - leaves other imports intact', async () => { | ||
| await render(FixtureComponent, { | ||
| importOverrides: [{ replace: ChildComponent, with: StubChildComponent }], | ||
| }); | ||
|
|
||
| expect(screen.getByText('Hello from stub')).toBeInTheDocument(); | ||
| expect(screen.getByText('Hello from other')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('importOverrides - throws on non-standalone component', async () => { | ||
| await expect( | ||
| render(NonStandaloneComponent, { | ||
| declarations: [NonStandaloneComponent], | ||
| excludeComponentDeclaration: true, | ||
| importOverrides: [{ replace: ChildComponent, with: StubChildComponent }], | ||
| } as any), | ||
| ).rejects.toThrow(/Cannot specify importOverrides on a template or non-standalone component/); | ||
| }); | ||
|
|
||
| test('importOverrides - throws when used with componentImports', async () => { | ||
| await expect( | ||
| render(FixtureComponent, { | ||
| componentImports: [ChildComponent], | ||
| importOverrides: [{ replace: ChildComponent, with: StubChildComponent }], | ||
| }), | ||
| ).rejects.toThrow(/Cannot specify both componentImports and importOverrides/); | ||
| }); | ||
|
|
||
| test('importOverrides - empty array is a no-op', async () => { | ||
| await render(FixtureComponent, { | ||
| importOverrides: [], | ||
| }); | ||
|
|
||
| expect(screen.getByText('Hello from child')).toBeInTheDocument(); | ||
| expect(screen.getByText('Hello from other')).toBeInTheDocument(); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @rpd10
Do you think this should be preferred over
componentImports, and couldcomponentImportsbe deprecated?