Feat: move work order relocates the device atomically#99
Closed
mukama wants to merge 3 commits into
Closed
Conversation
Replace magic enum values [3, 4] and [1, 2, 3, 4] with the existing WORK_ORDER_TYPES constant, addressing PR tetherto#98 review feedback.
A type-2 (move) work order auto-closes on creation, so it must perform the relocation itself — otherwise the closed WO records a move that never happened. createWorkOrder and createWorkOrdersBatch reuse submitWorkOrderAction (now taking an optional rackId) to push an updateThing to the part's own rack before recording the WO. Claude-Session: https://claude.ai/code/session_01Hk3GYz4TPiRmSs3Qmvv27V
mukama
force-pushed
the
feat/wo-move-atomic-relocation
branch
from
3d0f4ae to
1882ba3
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.