Conversation
* Initial plan * Initial investigation and plan for fixing eslint errors Co-authored-by: pselle <204372+pselle@users.noreply.github.com> * Fix all eslint errors by adding appropriate eslint-disable comments Co-authored-by: pselle <204372+pselle@users.noreply.github.com> * Run prettier --write to fix formatting issues Co-authored-by: pselle <204372+pselle@users.noreply.github.com> * Fix TypeScript build errors - Install @types/lodash for type definitions - Fix WebAssembly.compile type errors by casting Buffer to BufferSource - Fix subscription API call to properly use cursor or startLedger/endLedger - Create stub for guess_the_number contract to allow build without generated contracts - Remove now-unused eslint-disable comments since types are properly defined Co-authored-by: pselle <204372+pselle@users.noreply.github.com> * Add contract stub file to allow build Contract files are gitignored by default, but the stub is needed for the build to succeed when contracts haven't been generated yet. Co-authored-by: pselle <204372+pselle@users.noreply.github.com> * Update comment to use correct CLI name "Scaffold Stellar CLI" Co-authored-by: pselle <204372+pselle@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pselle <204372+pselle@users.noreply.github.com>
Pulling latest `main` and running `npm i` currently changes `package-lock.json`. Specifically, it adds the local packages from the `packages` folder. Let's check in this change.
Bumps the npm_and_yarn group with 1 update in the / directory: [js-yaml](https://github.com/nodeca/js-yaml). Updates `js-yaml` from 4.1.0 to 4.1.1 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
The frontend was not actually signing and sending the transaction. Now it is. to do: - [ ] `WalletButton` is not getting updated with new balance without page refresh, despite `updateBalance` call
- remove `useWalletBalance` hook
- add `balances` and `updateBalances` to `useWallet`
- `balances` is a map so we can `balances?.xlm?.balance ?? '-'`
- simplify & improve `useWallet`
- `signTransaction` defined top-level, always included in props
- `[state, setState]` removed in favor of flatter & easier-to-reason-about
state variables such as `[address, setAddress]`
- modify stub in src/contracts/guess_the_number.ts to include all
GuessTheNumber contract methods
Now when you guess a number, your wallet balance in the top bar updates
as expected, and working with wallet balances feels much more
straightforward.
fixup
Bumps [qs](https://github.com/ljharb/qs) from 6.14.0 to 6.14.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.0...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI had an issue linked to friendbot not working. This is a fix that removes friendbot and uses the seed account of the network instead of creating and funding a new account.