Merged
Conversation
chadoh
reviewed
Apr 8, 2026
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
chadoh
approved these changes
Apr 8, 2026
Member
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
Assuming the latest build passes with the TS directive removed, this looks great! Just one non-blocking question below.
Comment on lines
+39
to
+40
| if (!paging[id]) paging[id] = {} | ||
| const page = paging[id] |
Member
There was a problem hiding this comment.
I'm curious why this change was necessary. Was a linter mad about it? Seems like equivalent logic, if I'm not mistaken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI had an issue linked to friendbot not working. This is a fix that removes friendbot and uses the seed account of the network instead of creating and funding a new account.