Conversation
chadoh
requested changes
Apr 9, 2026
Member
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
The logic here looks sound enough (though—DEEP SIGH—wtf is the point of StellarWalletsKit and SEP-43 if every . damn . app needs to re-implement these outrageous workarounds?) but the UI logic is pretty smelly. Let's clean it up and then merge.
chadoh
reviewed
Apr 10, 2026
chadoh
approved these changes
Apr 10, 2026
Member
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
actually, whatever, let's keep stuff like that separate in the future but it looks great, thank you @hugo-heer !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPENDS ON #91
Closes #93
This PR adds a warning message on the wallet selection button for wallets that currently have integration issues with Stellar Wallets Kit. Each warning links directly to a dedicated GitHub issue created for the corresponding wallet.
Some wallets:
always trigger a popup when calling getAddress(), even if the user is already connected,
and/or do not support getNetwork().