Skip to content

🎨 Palette: Add ARIA labels and focus states to VeoProjectForm buttons#191

Open
thebearwithabite wants to merge 1 commit intomasterfrom
palette-veo-form-accessibility-14959735574219498419
Open

🎨 Palette: Add ARIA labels and focus states to VeoProjectForm buttons#191
thebearwithabite wants to merge 1 commit intomasterfrom
palette-veo-form-accessibility-14959735574219498419

Conversation

@thebearwithabite
Copy link
Copy Markdown
Owner

💡 What: Added ARIA labels and focus states to the script and audio upload icon-only buttons in VeoProjectForm.tsx.
🎯 Why: These buttons were purely visual (icons only) and had no text, making them completely inaccessible to screen readers. Furthermore, keyboard users tabbing through the interface had no visual indication of when these buttons were focused.
📸 Before/After: See the attached playwright UI test artifacts. When tabbing to the buttons, they now display a proper focus ring.
Accessibility:

  • Added aria-label to provide explicit names for screen readers.
  • Added aria-hidden="true" to the inner decorative SVG icons.
  • Implemented focus-visible:ring-2 focus-visible:ring-background/50 for clear keyboard navigation cues.

PR created automatically by Jules for task 14959735574219498419 started by @thebearwithabite

Added `aria-label` attributes to the script and audio upload icon-only
buttons in `VeoProjectForm.tsx` to improve screen reader accessibility.
Also added `aria-hidden="true"` to the inner SVG icons to prevent
redundant announcements, and added `focus-visible` Tailwind classes
(`focus-visible:ring-2 focus-visible:ring-background/50 focus-visible:outline-none`)
to ensure clear keyboard navigation visibility.

Co-authored-by: thebearwithabite <216692431+thebearwithabite@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant