Skip to content

🎨 Palette: Improve screen reader accessibility for AssetCard buttons #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebearwithabite wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Improve screen reader accessibility for AssetCard buttons #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions frontend_v2/src/components/veo/AssetLibrary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,9 @@ const AssetCard = ({ asset, onRemove, onUpload }: AssetCardProps) => {
<button
onClick={onRemove}
type="button"
aria-label="Remove asset"
className="absolute top-2 right-2 z-20 bg-black/60 backdrop-blur-md text-white/60 hover:text-white rounded-full p-1.5 opacity-0 group-hover:opacity-100 transition-all border border-white/10 scale-90 group-hover:scale-100">
<XMarkIcon className="w-3 h-3" />
<XMarkIcon className="w-3 h-3" aria-hidden="true" />
</button>

<div className="aspect-[4/3] bg-black/40 relative overflow-hidden">
Expand Down Expand Up @@ -290,8 +291,9 @@ const AssetCard = ({ asset, onRemove, onUpload }: AssetCardProps) => {
type="button"
onClick={handleCopyDescription}
className="text-white/20 hover:text-white transition-colors flex-shrink-0 mt-0.5"
title="Copy Name & Description">
{copied ? <CheckCircle2Icon className="w-3 h-3 text-green-400" /> : <ClipboardDocumentIcon className="w-3 h-3" />}
title="Copy Name & Description"
aria-label="Copy Name & Description">
{copied ? <CheckCircle2Icon className="w-3 h-3 text-green-400" aria-hidden="true" /> : <ClipboardDocumentIcon className="w-3 h-3" aria-hidden="true" />}
</button>
</div>
</div>
Expand Down
Loading