Skip to content

🎨 Palette: Make dynamic loading text accessible #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebearwithabite wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Make dynamic loading text accessible #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2024-03-16 - Make hover-only actions keyboard accessible
**Learning:** Actions hidden behind `opacity-0` and revealed with `group-hover:opacity-100` are completely inaccessible to keyboard-only users navigating via Tab. This is a common pattern for "secondary" actions like undo/delete buttons in lists.
**Action:** When using `opacity-0 group-hover:opacity-100` to hide secondary actions, always pair it with `focus-visible:opacity-100`, `focus-visible:ring-2`, and `focus-visible:outline-none` to ensure the action becomes visible and clearly highlighted when focused via keyboard navigation.

## 2024-05-20 - Accessible Cycling Text Elements
**Learning:** Dynamically changing text elements (like cycling loading messages) are silently updated and ignored by screen readers, leaving visually impaired users unaware of progress or status changes.
**Action:** Always apply `aria-live="polite"` and `aria-atomic="true"` to dynamically updating text containers to ensure screen readers announce the changing content without unnecessarily interrupting the user.
6 changes: 5 additions & 1 deletion frontend_v2/src/components/veo/LoadingIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ const LoadingIndicator: React.FC = () => {
<h2 className="text-2xl font-black mt-8 text-white italic tracking-tighter">
Generating Your Shot Book
</h2>
<p className="mt-2 text-white/50 text-center transition-opacity duration-500 font-medium">
<p
className="mt-2 text-white/50 text-center transition-opacity duration-500 font-medium"
aria-live="polite"
aria-atomic="true"
>
{loadingMessages[messageIndex]}
</p>
</div>
Expand Down
Loading