🛡️ Sentinel: [CRITICAL] Fix SQL injection in metadata_generator.py#208
🛡️ Sentinel: [CRITICAL] Fix SQL injection in metadata_generator.py#208thebearwithabite wants to merge 1 commit intomasterfrom
Conversation
- Fetch and use table schema columns as allowlist for filtering dictionary keys before dynamic SQL insert construction to prevent SQL injection. - Added journaling to .jules/sentinel.md detailing the vulnerability, learning, and prevention mechanisms. Co-authored-by: thebearwithabite <216692431+thebearwithabite@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The
save_file_metadatamethod inmetadata_generator.pyconstructed anINSERT OR REPLACE INTOquery by directly formatting the keys of the user-providedmetadatadictionary into the column names string({column_names}). This allowed an attacker to inject arbitrary SQL statements if they could control the keys of themetadatadictionary.🎯 Impact: This could be exploited to bypass database logic, corrupt internal data states, or potentially leverage local paths to perform dangerous file system actions, depending on application integrations.
🔧 Fix: Modified
save_file_metadatato usePRAGMA table_info(file_metadata)to fetch a list of valid columns and filter out keys from themetadatadictionary that don't belong to the schema, sanitizing the data structures prior to column string format construction.✅ Verification: Tested against a sample database and mock file system paths injecting a payload to verify that only valid schema keys passed into the executed query instead of the injected payload. All project specific scripts also verified correctly and code review marked the implementation correct.
PR created automatically by Jules for task 8468205289644561646 started by @thebearwithabite