Skip to content

🎨 Palette: Improve sidebar navigation accessibility #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebearwithabite wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Improve sidebar navigation accessibility #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2024-03-16 - Make hover-only actions keyboard accessible
**Learning:** Actions hidden behind `opacity-0` and revealed with `group-hover:opacity-100` are completely inaccessible to keyboard-only users navigating via Tab. This is a common pattern for "secondary" actions like undo/delete buttons in lists.
**Action:** When using `opacity-0 group-hover:opacity-100` to hide secondary actions, always pair it with `focus-visible:opacity-100`, `focus-visible:ring-2`, and `focus-visible:outline-none` to ensure the action becomes visible and clearly highlighted when focused via keyboard navigation.
## 2024-04-12 - Sidebar Navigation Accessibility
**Learning:** React Router Links used for navigation items without `aria-current` lack semantic indication of the active page for screen readers, while visible text is sufficient without additional `aria-label`. Redundant `aria-hidden="true"` on decorative icons inside the link improves screen reader experience.
**Action:** Always add `aria-current={isActive ? 'page' : undefined}` to active navigation links, apply explicit `focus-visible:ring-2 focus-visible:ring-background/50 focus-visible:outline-none` classes for keyboard accessibility, and hide decorative inner icons with `aria-hidden="true"`.
4 changes: 3 additions & 1 deletion frontend_v2/src/components/layout/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,17 @@ export default function Sidebar() {
<Link
key={item.to}
to={item.to}
aria-current={isActive ? 'page' : undefined}
className={cn(
"flex items-center gap-3 px-4 py-3 rounded-lg transition-all duration-300",
"focus-visible:ring-2 focus-visible:ring-background/50 focus-visible:outline-none",
isActive
? "bg-primary text-white"
: "text-white/60 hover:bg-white/10 hover:text-white",
item.highlight && !isActive && "text-warning hover:text-warning"
)}
>
<Icon size={20} />
<Icon size={20} aria-hidden="true" />
<span className="font-medium">{item.label}</span>
</Link>
)
Expand Down
Loading