Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection vulnerability in metadata generator#231

Open
thebearwithabite wants to merge 1 commit intomasterfrom
sentinel-sql-injection-fix-12165267220019104563
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection vulnerability in metadata generator#231
thebearwithabite wants to merge 1 commit intomasterfrom
sentinel-sql-injection-fix-12165267220019104563

Conversation

@thebearwithabite
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: SQL injection vulnerability in metadata_generator.py via untrusted dictionary keys passed to save_file_metadata and injected directly into query strings.
🎯 Impact: Attackers could inject arbitrary SQL to modify schemas or drop tables (e.g., column name injection).
πŸ”§ Fix: Fetched schema with PRAGMA table_info and filtered metadata keys against this explicitly allowlisted set before building the dynamic INSERT query.
βœ… Verification: Tested via a mock script executing a drop table payload, verified table persistence and column sanitization. All unit tests successfully executed.


PR created automatically by Jules for task 12165267220019104563 started by @thebearwithabite

…enerator

Co-authored-by: thebearwithabite <216692431+thebearwithabite@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant