Skip to content

chore: remove package-versions-deprecated dependency#810

Open
reydajp wants to merge 1 commit into
thecodingmachine:masterfrom
reydajp:chore/remove-package-versions-deprecated
Open

chore: remove package-versions-deprecated dependency#810
reydajp wants to merge 1 commit into
thecodingmachine:masterfrom
reydajp:chore/remove-package-versions-deprecated

Conversation

@reydajp

@reydajp reydajp commented Jun 9, 2026

Copy link
Copy Markdown

Summary

Remove the abandoned composer/package-versions-deprecated dependency.

GraphQLite only used PackageVersions\Versions to derive a cache namespace from the installed package version. This PR replaces that usage with Composer 2's built-in Composer\InstalledVersions.

Changes

  • Replace PackageVersions\Versions with Composer\InstalledVersions
  • Add composer-runtime-api requirement
  • Remove composer/package-versions-deprecated
  • Remove the related Composer plugin allow-list entry

Tests

  • composer validate --strict
  • git diff --check
  • composer audit --abandoned=fail
  • composer cs-check
  • vendor/bin/phpstan analyse -c phpstan.neon --no-progress src/SchemaFactory.php src/Utils/NamespacedCache.php
  • vendor/bin/phpunit --no-coverage tests/Utils/NamespacedCacheTest.php tests/SchemaFactoryTest.php

@oojacoboo

Copy link
Copy Markdown
Collaborator

@reydajp thanks for the PR. You'll need to rebase off master which fixes the CI issues.

@reydajp reydajp force-pushed the chore/remove-package-versions-deprecated branch from fb471e7 to 2848ad1 Compare June 11, 2026 08:03
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.84%. Comparing base (53f9d49) to head (2848ad1).
⚠️ Report is 156 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #810      +/-   ##
============================================
- Coverage     95.72%   94.84%   -0.88%     
- Complexity     1773     1893     +120     
============================================
  Files           154      176      +22     
  Lines          4586     4987     +401     
============================================
+ Hits           4390     4730     +340     
- Misses          196      257      +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@reydajp

reydajp commented Jun 11, 2026

Copy link
Copy Markdown
Author

@reydajp thanks for the PR. You'll need to rebase off master which fixes the CI issues

Rebased onto latest master and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants