Fix border-widths that crash Vite when compiling#1356
Open
Floppy wants to merge 2 commits into
Open
Conversation
Set to 0px instead of 0
Set to 0px instead of 0 to fix compilation crash with Vite
Author
|
OK, I found out where it's going wrong; I'm also including So, yeah, I guess Vite is crashing because of that calculation and the fact that the border-width as set is dimensionless. |
Author
|
BTW, I appreciate that this might well be the wrong place to fix my problem. I'm trying to create a reproduction for Vite as it's probably their bug at heart, but haven't got there yet. This PR is open in case it's a useful change for you anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using
sasscto build my CSS for ages, and bootswatch has been working great. However, I changed to Vite recently, and it would crash without any extra info when compiling the Vapor theme. I narrowed it down to this$border-widthvariable - if it's set to0, it crashes, if it's0pxit works fine.I don't know why this is the case either on the Vite or the Bootswatch side, but it does seem to fix it. I wondered if some calculation is done elsewhere inside Bootstrap using border-width that gets confused if the
pxspecifier isn't included, perhaps.