Platform/Qualcomm/NordBoardPkg: add Nord Generic board by b49020 · Pull Request #1012 · tianocore/edk2-platforms

b49020 · 2026-07-14T08:18:38Z

Add the Qualcomm Nord Generic board port, built on the MinPlatform staged-boot model (PcdBootStage, Core{Common,Pei,Dxe}Lib, Stage1-4 includes, BoardInitLib, PlatformInitPei/ReportFvPei) and the QualcommPlatformPkg / QualcommSiliconPkg foundation. It runs as the TF-A BL33 payload (SEC first in a multi-FV FD at the BL33 base) and boots to the OS.

The package is named generically (NordBoardPkg) so it can host further
Qualcomm Nord-family boards.

Included:

NordBoardPkg.dsc/.fdf/.dec, Include/Dsc/Stage1-4 and Include/Fdf/FlashMap.
BoardInitLib (MinPlatform board hooks) and OemMiscLib (SMBIOS).
USER_PROVIDED_DTB build option with DeviceTree/ (DtPlatformDxe + the UserDTB fork); the board uses GENI UART, UFS and connect-all discovery.

The memory map needs no board-specific drivers: ArmPlatformLib describes system DRAM (including the upper banks) from the SMEM RAM partition table during PEI, and the OS reserved-memory carveouts are carried in the
device tree.

Developed in an AI assisted workflow.

idlethread · 2026-07-14T14:34:10Z

-    (FixedPcdGet64 (PcdFdBaseAddress) + FixedPcdGet64 (PcdSystemMemorySize))
-    - (FixedPcdGet64 (PcdTrace32DdrBase) + FixedPcdGet64 (PcdTrace32DdrSize))
-    );
+  //


Make this T32 block conditional ?

I suppose you mean here to make T32 support only available in edk2 DEBUG builds, right?

@vishalo do you have any comments on this with respect to Glymur?

Commit: 50d3bd4 now builds t32 under debug builds only.

This allows us to load symbols on t32 simulator from crashdumps. We have plenty of cases where we have to debug RELEASE builds. Let's keep this.

A platform can still override this in it's own .dsc but we can't enable JTAG in the release builds by default. JTAG is also disabled by default in default secure boot policy.

b49020 · 2026-07-15T06:24:26Z

Update: rather than IQ10 EVK specific board package, renamed it to NordBoardPkg to cover all the Nord based other board variants. The DTB for sure needs to be board specific though.

trsoni

so we don't want to add Assisted-by AI tag?

ricardosalveti · 2026-07-16T01:57:06Z

so we don't want to add Assisted-by AI tag?

I don't believe the contribution guidelines for edk2 requires it at this point.

trsoni · 2026-07-16T03:33:35Z

so we don't want to add Assisted-by AI tag?

I don't believe the contribution guidelines for edk2 requires it at this point.

Sorry but it looks odd that Qualcomm is not declaring that anywhere in PR. It is not about policy of the project but more transparency I think could help.

b49020 · 2026-07-16T05:32:54Z

so we don't want to add Assisted-by AI tag?

I don't believe the contribution guidelines for edk2 requires it at this point.

Sorry but it looks odd that Qualcomm is not declaring that anywhere in PR. It is not about policy of the project but more transparency I think could help.

Updated PR description to mention it.

ricardosalveti · 2026-07-16T14:36:54Z

so we don't want to add Assisted-by AI tag?

I don't believe the contribution guidelines for edk2 requires it at this point.

Sorry but it looks odd that Qualcomm is not declaring that anywhere in PR. It is not about policy of the project but more transparency I think could help.

We also have upstream projects that do ask explicitly to not add the assisted tag (expecting the submitter to completely own the work, even if done with help from AI), that is why our internal guidelines (check the guidelines from OSDO) suggests following the upstream project policies.

b49020 · 2026-07-16T15:06:44Z

Commit df14b8f has been added to introduce QualcommMinPlatformPkg such that the MinPlatform related stage includes can be shared.

trsoni · 2026-07-16T17:17:22Z

so we don't want to add Assisted-by AI tag?

I don't believe the contribution guidelines for edk2 requires it at this point.

Sorry but it looks odd that Qualcomm is not declaring that anywhere in PR. It is not about policy of the project but more transparency I think could help.

Updated PR description to mention it.

Thank you. I have also filed the github issue #1014 . I don't see much traction on the past github issues though in this project, I can send it to mailing list if that is most desired to initiate the discussion.

QcomPlatformPkg.dec only declared the UFS register-window PCDs used by QcomUfsHcDxe. Declare them in QualcommPlatformPkg as PcdUfsHcMmioBase/Size (UINT64), point QcomUfsHcDxe and RB3Gen2 at them, drop the unused QcomPlatformPkg dependency from ArmPlatformLib, and delete the package. No functional change. Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

b49020 · 2026-07-17T07:01:07Z

While refactoring changes further found another duplicated package, removed that as part of this 0541364.

ricardosalveti · 2026-07-17T18:25:08Z

@vishalo mind a review?

vishalo · 2026-07-19T18:34:54Z

@vishalo mind a review?

Thank you @b49020 and @ricardosalveti .

Hi @ricardosalveti, some of these patches don't align with our internal discussions. Let's reconvene and work through them together to make sure we're aligned before moving forward.

ricardosalveti · 2026-07-20T15:07:14Z

Hi @ricardosalveti, some of these patches don't align with our internal discussions. Let's reconvene and work through them together to make sure we're aligned before moving forward.

Sure, but what is actually conflicting here?

Would be nice if you could still help reviewing the PR anyway.

vishalo

Can we keep this around, till we have plan on where things go?

vishalo · 2026-07-21T06:30:11Z

+  # instance for RELEASE builds.
+  #
+!if $(TARGET) == DEBUG
  PeCoffExtraActionLib|QualcommPlatformPkg/Library/DebugPecoffExtraActionTrace32Lib/DebugPecoffExtraActionTrace32Lib.inf


We have plenty of cases where we have to debug RELEASE builds.

Then keep it platform specific where needed.

vishalo · 2026-07-21T06:33:52Z

-    (FixedPcdGet64 (PcdFdBaseAddress) + FixedPcdGet64 (PcdSystemMemorySize))
-    - (FixedPcdGet64 (PcdTrace32DdrBase) + FixedPcdGet64 (PcdTrace32DdrSize))
-    );
+  //


This allows us to load symbols on t32 simulator from crashdumps. We have plenty of cases where we have to debug RELEASE builds. Let's keep this.

vishalo · 2026-07-21T06:35:15Z

-  mMemRegions[mNumMemRegions].CacheAttributes   = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE;
-  mNumMemRegions++;
+  /* IMEM Cookies (only when the platform configured the region) */
+  if ((FixedPcdGet64 (PcdIMemCookiesBase) != 0) && (FixedPcdGet64 (PcdIMemCookiesSize) != 0)) {


If we need to do this, it is better to use FeaturePcd, and not rely on address PCD. How about remove it once DT support is enabled ?

Switched to use FeaturePcd for all the optional memory region mapping. And we shouldn't enforce boot DT for every platform, Pcds are the de-facto standard ways of edk2 configuration so we should support that option too.

vishalo · 2026-07-21T06:37:16Z

+  @retval Other  Pointer to the validated table.
+**/
+STATIC
+USABLE_RAM_PARTITION_TABLE *


SmemLib should not add RamPartitionTable , can we use SmemLib from @gparikh ? #1015

Reworked for SmemLib to abstract out the RamPartitionTable.

can we use SmemLib from @gparikh ? #1015

As I see it is full-fledged SMEM driver with a lot of redundant functionality not needed for the Nord board support. So, there isn't a reason to derail Nord board support just on the SMEM PR. For sure, the SMEM driver can be extended later to add functionality as and when required.

vishalo · 2026-07-21T06:40:30Z

+  VERSION_STRING                 = 1.0
+
+[Binaries]
+  BIN|nord-board.dtb


This is not ideal - we will have to recompile UEFI if dtb requires update. Downstream has partition-based solution, we can enable that.

This can be supported until we have the partition-based implementation available and merged here, shouldn't be a problem to merge this as is and later improve.

Happy to work with you to get those pieces enabled ..

No please we don't want to enforce partition-based implementation for every use-case. It is already implemented in non-standard way to use EFI signatures on top of U-Boot FIT blob for authentication.

We really have to review it carefully to have a partition based solution upstream aligning with Arm SystemReady practices.

Gate the optional memory regions ArmPlatformLib maps (SMEM, boot DT, IMEM cookies and the Trace32 DDR debug buffer) on per-region boolean FeaturePcds instead of inferring "present" from a non-zero base/size, which conflated a valid base of 0 with "disabled" and could not be overridden per board. Each flag defaults to FALSE so a board maps only what it provides. Also add PcdUfsHcEnable and map the UFS register window under it, which NonDiscoverablePciDeviceDxe does not map itself. Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

Add a functional SmemLib that reads SMEM items by item id so RamPartitionTableLib can obtain the usable RAM partition table; previously only SmemLibNull existed. The library is a generic SMEM item accessor with no knowledge of any item's payload, so the usable RAM partition table's magic validation and fallback scan live in the consumer, RamPartitionTableLib. Move the shared RamPartition.h from QualcommPlatformPkg into QualcommSiliconPkg (consumers already depend on it) and bound the fallback scan with PcdSmemSize. Co-developed-by: Tyler Baker <tyler.baker@oss.qualcomm.com> Signed-off-by: Tyler Baker <tyler.baker@oss.qualcomm.com> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

RB3Gen2's OemMiscLib is board-agnostic (it reads platform PCDs). Move it into the shared QualcommPlatformPkg so other Qualcomm boards can reuse it, and point RB3Gen2 at it. Also migrate the SMBIOS OEM PCDs it consumes from KodiakPkg to QualcommPlatformPkg so the shared library no longer depends on a SoC package. No functional change. Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

Move the reusable MinPlatform pieces out of GlymurOpenBoardPkg into a new Platform/Qualcomm/QualcommMinPlatformPkg so multiple Qualcomm boards can share them, and migrate GlymurOpenBoardPkg onto it: - the Stage1-4 DSC skeleton, and - the flash-map include, which now derives the FV/NV offsets and base addresses from the per-board sizes each board FDF sets. Board-specific content (DSC overrides and the flash sizes/NV bases) stays in the board. No functional change: the firmware volume is identical. Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

…ilds The Trace32 PeCoffExtraActionLib emits JTAG hooks only useful with a Trace32 debugger. Gate it behind $(TARGET) == DEBUG and use BasePeCoffExtraActionLibNull for RELEASE. Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

Add the Qualcomm Nord Generic board port, built on the MinPlatform staged-boot model and the QualcommPlatformPkg/QualcommSiliconPkg foundation. It runs as the TF-A BL33 payload and boots to the OS; the name is generic so it can host further Nord-family boards. The staged-boot Stage1-4 skeleton comes from the shared QualcommMinPlatformPkg; Nord ships its .dsc/.fdf/.dec, board-local flash map, BoardInitLib and DeviceTree (USER_PROVIDED_DTB), and reuses the shared OemMiscLib. ArmPlatformLib sizes DRAM from the SMEM RAM partition table, so no board-specific memory drivers are needed. Co-developed-by: Tyler Baker <tyler.baker@oss.qualcomm.com> Signed-off-by: Tyler Baker <tyler.baker@oss.qualcomm.com> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

b49020 requested review from ricardosalveti and vishalo July 14, 2026 08:18

b49020 requested a review from leiflindholm as a code owner July 14, 2026 08:18

tianocore-assign-reviewers Bot assigned b49020 Jul 14, 2026

idlethread reviewed Jul 14, 2026

View reviewed changes

b49020 force-pushed the nord-minplat branch from dc8d37c to ef46fc0 Compare July 15, 2026 06:21

b49020 changed the title ~~Platform/Qualcomm/Iq10EvkBoardPkg: add IQ-10 EVK board (SA8797P)~~ Platform/Qualcomm/NordBoardPkg: add Nord Generic board Jul 15, 2026

trsoni reviewed Jul 15, 2026

View reviewed changes