Skip to content

ws2812: fix PIO TX FIFO overflow on rp2040/rp2350 dropping LEDs #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deadprogram wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −0
Open

ws2812: fix PIO TX FIFO overflow on rp2040/rp2350 dropping LEDs #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ws2812/ws2812_rp2_pio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package ws2812
import (
"image/color"
"machine"
"runtime"

pio "github.com/tinygo-org/pio/rp2-pio"
"github.com/tinygo-org/pio/rp2-pio/piolib"
Expand All @@ -27,6 +28,9 @@ func newWS2812Device(pin machine.Pin) Device {
writeColorFunc: func(_ Device, buf []color.RGBA, brightness uint8) error {
for _, c := range buf {
r, g, b := applyBrightness(c, brightness)
for ws.IsQueueFull() {
runtime.Gosched()
}
ws.PutRGB(r, g, b)
}
return nil
Expand Down