Fix bug that causes crash/white screen on Windows, add checks - #132
Merged
dengr1065 merged 2 commits intoApr 12, 2026
Conversation
Fixes yet another regression from migrating to Rspack, may be reverted eventually if Rspack behavior changes
This makes it easy to catch bugs that involve executing webworkers inappropiately
Collaborator
|
Thanks for the bug fix! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug caused by a difference in behavior of
import.meta.webpackContextbetween Rspack and Webpack.It also add checks to make sure that webworkers are not executed on the main thread (which was part of the cause of the crash/white screen).