pull - #119
Closed
TheInfamousToTo wants to merge 8 commits into
Closed
Conversation
- Add Winston file transports for persistent logging (error.log, combined.log) - Update Docker setup with logs volume mount and directory creation - Enhance .gitignore to protect sensitive configuration files - Update timezone to Asia/Bahrain and clean up docker-compose.yml - Use relative paths for volume mounts for better portability
…builds - Add create-release.yml: Automatically creates GitHub releases when version file changes - Add docker-build.yml: Builds and pushes Docker images to Docker Hub with DOCKERHUB_USERNAME/DOCKERHUB_TOKEN - Update docker-image.yaml: Builds and pushes Docker images to GitHub Container Registry (ghcr.io) - Workflows follow proven patterns from PiHoleVault reference implementation - Support for multi-platform builds (linux/amd64, linux/arm64) - Proper version parsing and tag generation using metadata-action - Added debug steps for troubleshooting version parsing issues - Added version file (v1.0.0) to trigger release workflow
Test Notification Feature: - Add automatic test notifications on application startup - Support for Discord webhooks, Telegram bots, and Discord bots - Configurable via testNotification.enabled in config - Add manual test-notification command for on-demand testing - Comprehensive error handling and logging - Add documentation for the new feature - Ensure notifications confirm platform connectivity on startup GitHub Actions Fix: - Fix YAML syntax error in create-release.yml workflow - Improve multiline string handling in changelog generation - Use heredoc for better string formatting
- Fix command structure: Use name/params/run instead of definition object - Fix case sensitivity: Use toLowerCase() for platform name comparisons - Fix Discord platform logic: Handle Discord bot context properly vs webhook These fixes resolve the issues that prevented the application from running: 1. Command loader can now parse the test-notification command correctly 2. Platform name matching works with lowercase names from application 3. Discord bot commands return replies instead of trying to call .send() method Tested successfully with Docker compose - application starts without errors.
- Replace local build with ghcr.io/theinfamoustoto/hoyolab-auto:latest - Improves startup time by using pre-built images - Ensures consistent environment across deployments - Reduces local storage requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.